Review state should be translatable on folder_contents page

[terapyon]

BUG REPORT

Review state should be translatable on folder_contents page

What I expect to happen:

@@getVocabulary should return new property review_state_title and this property should be used on the page. Because review_state property already be used view class as state-private, it means review_state could not be translatable.

What actually happened:

@@getVocabulary

review_state: "private"

What version of Plone

Plone 5.1.2

[erral]

If we just add _t('') to address this, we will have to translate review state names also in mockup. Perhaps it's a first step, but I think we should take the translations from plone domain. Although achieving that from mockup is like science-fiction for me 😄

[vincentfretin]

This issue is a hard one. You need to get the title that is defined for the workflow state, not try to translate the id. There may be a change to do in plone.app.content?

[vincentfretin]

The javascript call a view getVocabulary to retrieve the data for each item.

Btw @tisto I didn't test volto recently, but do you have the review state correctly translated in folder contents in volto? Maybe you can shed some light on this issue? How do you do it properly in volto?

[erral]

If I am not wrong we translate all workflow and content-type names in plone.restapi endpoints. I was working on it in a Sprint some time ago, indeed 😄

[vincentfretin]

I guess you still need the review_state as id for the filters or for the style, so we should add the review_state_title (already translated with translate(workflow_label, context=self.request) in the returned json?

[erral]

Yeah, something like that. See what we did with transitions, for instance: https://github.com/plone/plone.restapi/blob/master/src/plone/restapi/services/workflow/info.py#L54

[vincentfretin]

Ah ah, so you know there is a change do be made in the python code that create this json and then a change in mockup to use the new key in the json to show the workflow state.

[erral]

I had to make 2 changes to achieve this:

• Expose an additional 'translated_review_state' attribute in the vocabulary: plone/plone.app.content@0d74f69 plone/plone.app.content@9aaaa75
• Configure the folder_contents view to use that 'translated_review_state' as the rendered value: plone/mockup@16f9973

A similar strategy can be used for portal types. I find the vocabulary changes a bit hacky, but I think that there is no other way to achieve this.

I didn't just exchange the value of the review_state with its translated version because the original review_state value could be useful for other purposes, not just for rendering it in folder_contents view.

Any comment?

[vincentfretin]

You're right about not changing the value for review_state, otherwise it would be a breaking change.
I left a comment on each commit.

[vincentfretin]

@erral You can create a PR as draft for your branch so we have more visibility you are working on it.

[erral]

I thought I already did this, sorry. I created plone/plone.app.content#207 and plone/mockup#1001

[jensens]

So, just checked, here it translates the state: 6.0.2 classicui