Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in Link Persists on 404 Pages Even After Logging In (Plone Classic UI) #4096

Open
rohnsha0 opened this issue Feb 3, 2025 · 4 comments
Open

Comments

@rohnsha0
Copy link
Contributor

rohnsha0 commented Feb 3, 2025

BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)

On 404 pages in Plone Classic UI, the "Log in" button persists even after the user has logged in.

Image

What I did:

  • Navigated to a non-existent page in Plone, triggering a 404 error page.
  • Logged in to the Plone Classic UI.

However, when navigating to the site root, the user is logged in

What I expect to happen:

After logging in, the "Log in" button should change to reflect the authenticated state (e.g., display the username or a "Log out" option).

What actually happened:

  • Even after logging in, the "Log in" button persists on 404 pages in the Plone Classic UI.
  • This may cause confusion as it appears that the user is not logged in.

What version of Plone/ Addons I am using:

  • Plone 6.1.0rc2.dev0 (6107)
  • CMF 3.6
  • Zope 5.12
  • Python 3.11.11 (main, Dec 29 2024, 13:41:59) [GCC 14.2.1 20240910]
  • PIL 11.0.0 (Pillow)
  • WSGI: On
  • Server: waitress 3.0.2
@rohnsha0 rohnsha0 changed the title 1Log in1 Link Persists on 404 Pages Even After Logging In (Plone Classic UI) Log in Link Persists on 404 Pages Even After Logging In (Plone Classic UI) Feb 3, 2025
@stevepiercy
Copy link
Contributor

Per my comment, #4094 (comment), we should consider a redirect after login, either to the site root (my preference) or to the same 404 page.

After logging in, you can visit /404, and the Login link still displays, but should instead either be removed (my preference) or Logout displayed.

@rohnsha0
Copy link
Contributor Author

rohnsha0 commented Feb 3, 2025

Per my comment, #4094 (comment), we should consider a redirect after login, either to the site root (my preference) or to the same 404 page.

After logging in, you can visit /404, and the Login link still displays, but should instead either be removed (my preference) or Logout displayed.

I agree with the given suggestion!

@petschki
Copy link
Member

petschki commented Feb 3, 2025

The redirection in the login view got fixed here #4094 ...
When using the login "modal" there is one more issue with the modal options: #4100

The persistend login link on "not found" pages is a complete different story, because this page template has no authentication information and therefore displays the "anon-tools" viewlet.

@rohnsha0
Copy link
Contributor Author

rohnsha0 commented Feb 3, 2025

The persistend login link on "not found" pages is a complete different story, because this page template has no authentication information and therefore displays the "anon-tools" viewlet.

I understand.
But my question is, how a user will userstand that the login is a success? as there is no feedback!
However my question might be irrelevant, but just out of curiousity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants