Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: web server virtual hosting and certificates sections are inconsistent #73

Closed
stevepiercy opened this issue Apr 21, 2017 · 3 comments

Comments

@stevepiercy
Copy link
Contributor

I noticed this because I'm muddling through how to use Let's Encrypt for secure certificates and auto-renewal in a cron job together with this project, as mentioned in #61.

In the documentation, from the note under Virtual hosting setup:

If you are setting up an https server, you must supply certificate and key files. The files will be copied from your local machine (the one containing the playbook) to the target server.

Then in the next section, Certificates:

To use files that already exist on the controlled server, use:

I think these two items inconsistent. If you agree, I volunteer to provide the text in a PR.

@stevepiercy
Copy link
Contributor Author

That helps, but did not address the issue. If the files already exist on the controlled server, then they will not be copied from your local machine (the one containing the playbook) to the target server. Or do I misunderstand?

@stevepiercy stevepiercy reopened this Apr 25, 2017
@ramiroluz
Copy link
Member

From the documentation you linked I understood that the keys will not be copied if you chose to use keys that are already on the controlled machine.

@stevepiercy
Copy link
Contributor Author

There's still a conflict between the note and Certificates section.

The note still says:

The files will be copied from your local machine (the one containing the playbook) to the target server.

but the Certificates section says:

Certificate files may be specified in one of two ways.
...
To use files that already exist on the controlled server, use:

I'll submit a PR with a suggested improvement for cohesiveness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants