Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding custom roles to sharing tab #23

Open
djay opened this issue Jul 12, 2013 · 5 comments
Open

Allow adding custom roles to sharing tab #23

djay opened this issue Jul 12, 2013 · 5 comments

Comments

@djay
Copy link
Member

djay commented Jul 12, 2013

Plone currently doesn't have anywhere in the control panel that lets you add custom roles. This is currently possible via generic setup (see plone.app.workflow).
If the workflowmanager is going into the plone core then this seems the logical place to do it. Not sure where in the UI however.

@djay
Copy link
Member Author

djay commented Jul 12, 2013

BTW, I don't know where to put this but we really need to sort out naming things in Plone. I'm conistantly having issues with describing to clients that Plone "roles" are not what they thing they are. Plone roles should be renamed privileges and is really just a aggregation of permissions. What customers think of roles is normally best modeled as a group in role e.g. news_editors. ie customers consider a role to privileges in a certain context. Perhaps there is a way to encourage users via the UI to consider groups more?
We should also fix up Can Edit vs Editor mismatch.
We should also consider if we need both global privilege assignment and the sharing tab at the root of the site.

@davisagli
Copy link
Member

Good points. Gonna submit a PLIP for Plone 5?

I don't think "privilege" helps clarify things much; it's a synonym of permission.

@djay
Copy link
Member Author

djay commented Jul 12, 2013

Is there a PLIP already from p.a.workflowmanager being put into plone 5?
If so I can do a PLIP for the sharing tab stuff.

Maybe privilege is the wrong word but I think when outside of ZMI we need a word that is much closer to permission or group of permissions, and to drop the use of the word role. "Permission Set"?

@davisagli
Copy link
Member

The existing plone.app.workflowmanager PLIP is basically defunct because no one's working on it. Probably makes sense to keep the sharing tab stuff separate in any case.

Permission Set sounds okay.

@djay
Copy link
Member Author

djay commented Jul 12, 2013

Given I've had nothing to do with the workflowmanager development I'm not sure I want to put my hand up to bring it into the core. I'd imagine it will a) need to change after the js refactoring b) in someways be less risky to integrate after toolbar is in place.
It would be a shame not to include it plone5. I will think about if it makes sense to have a sharing tab control panel without workflowmanager, but by initial impression is that it doesn't make sense. workflowmanager is the only place in the Plone UI where zope permissions appear.

On 12/07/2013, at 1:16 PM, David Glick [email protected] wrote:

The existing plone.app.workflowmanager PLIP is basically defunct because no one's working on it. Probably makes sense to keep the sharing tab stuff separate in any case.

Permission Set sounds okay.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants