Skip to content

Commit

Permalink
Pass LANGUAGE to docker
Browse files Browse the repository at this point in the history
  • Loading branch information
davisagli committed Aug 5, 2024
1 parent 8243834 commit 67b3a88
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# Volto development
# Allow setting the language for backend-docker-start. Default is `en`.
LANGUAGE ?=en

### Defensive settings for make:
# https://tech.davis-hansson.com/p/make/
Expand Down Expand Up @@ -170,7 +168,7 @@ release-notes-copy-to-docs: ## Copy release notes into documentation

.PHONY: backend-docker-start
backend-docker-start: ## Starts a Docker-based backend for development
$(MAKE) -C "./packages/volto/" backend-docker-start -e $(LANGUAGE)
$(MAKE) -C "./packages/volto/" backend-docker-start

.PHONY: backend-docker-detached-start
backend-docker-detached-start: ## Starts a Docker-based backend in detached mode (daemon)
Expand Down
5 changes: 4 additions & 1 deletion packages/volto/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ MAKEFLAGS+=--no-builtin-rules
# Project settings (read from repo root)
include ../../variables.mk

# Allow setting the language for backend-docker-start. Default is `en`.
LANGUAGE ?=en

# Recipe snippets for reuse

CHECKOUT_BASENAME="$(shell basename $(shell realpath ./))"
Expand Down Expand Up @@ -100,7 +103,7 @@ release-notes-copy-to-docs: ## Copy release notes into documentation

.PHONY: backend-docker-start
backend-docker-start: ## Starts a Docker-based backend for development
docker run -it --rm --name=backend -p 8080:8080 -v volto-backend-data:/data -e SITE=Plone -e ADDONS='$(KGS)' $(DOCKER_IMAGE)
docker run -it --rm --name=backend -p 8080:8080 -v volto-backend-data:/data -e SITE=Plone -e ADDONS='$(KGS)' -e LANGUAGE='$(LANGUAGE)' $(DOCKER_IMAGE)

.PHONY: frontend-docker-start
frontend-docker-start: ## Starts a Docker-based frontend for development
Expand Down

0 comments on commit 67b3a88

Please sign in to comment.