-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the Table background color when inverted and basic active at same time #4605
Conversation
✅ Deploy Preview for volto canceled.
|
@lord2anil can you open a PR on a branch in the volto repo? GitHub Actions will only run on branches inside the Plone organization. @fredvd @sneridagh would you please take a look at permissions for @lord2anil to open a PR in volto? We might need to make an adjustment. |
@stevepiercy It's primarily a workflow issue I think. The towncrier checks for example have run for lord2anil's Pull Request from his own workspace, because the on: definition explicitly mentions pull_request. https://github.com/plone/volto/actions/runs/4508573482 The other Volto workflows are registered on push: for a branch on the main repo. @sneridagh We need to take a look at the workflows so that the necessary ones like unit tests are also running on pull requests. . |
✅ Deploy Preview for plone-components canceled.
|
@lord2anil Thanks for the contribution! On testing this PR, I've noticed a couple of issues:
Are you able to make these changes and we can work towards getting this PR merged? |
@@ -0,0 +1 @@ | |||
fixed the Table background color when inverted and basic active at same time @lord2anil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the Table background color when inverted and basic active at same time @lord2anil | |
Fixed the table background color when its `inverted` and `basic` styles are active at the same time. @lord2anil |
Thanks for the feedback. Due to time constraints, I cannot implement the changes right now. |
The fix isn't what is needed. Due to the time constraints of the author I am closing this pull request, we can open a new one with the solution proposed by @JeffersonBledsoe |
closes #4603