Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the Table background color when inverted and basic active at same time #4605

Closed
wants to merge 3 commits into from

Conversation

lord2anil
Copy link
Contributor

closes #4603

@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 2f3da83
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/641d47b17bc75f00084bca4c

@stevepiercy
Copy link
Collaborator

@lord2anil can you open a PR on a branch in the volto repo? GitHub Actions will only run on branches inside the Plone organization. @fredvd @sneridagh would you please take a look at permissions for @lord2anil to open a PR in volto? We might need to make an adjustment.

@fredvd
Copy link
Member

fredvd commented Mar 24, 2023

@stevepiercy It's primarily a workflow issue I think. The towncrier checks for example have run for lord2anil's Pull Request from his own workspace, because the on: definition explicitly mentions pull_request.

https://github.com/plone/volto/actions/runs/4508573482

The other Volto workflows are registered on push: for a branch on the main repo. @sneridagh We need to take a look at the workflows so that the necessary ones like unit tests are also running on pull requests. .

@ichim-david ichim-david added the 99 tag: UX Accessibility Accessibility issues label Jul 21, 2024
Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit cb84415
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66a2b823551f080008a2802a

@JeffersonBledsoe JeffersonBledsoe self-requested a review July 23, 2024 09:58
@JeffersonBledsoe
Copy link
Member

@lord2anil Thanks for the contribution! On testing this PR, I've noticed a couple of issues:

  • The 'black' colour doesn't match that of 'inverted'. This could cause an issue if the themeing system has been used to change the colour of 'inverted'.
    • I would suggest solving this in a .less file while you can check for .inverted.basic and read from the @invertedBackground and other inverted table variables
  • The current fix only applies to edit mode and so it breaks again in view mode. The above suggestion about using the .less files should solve this.

Are you able to make these changes and we can work towards getting this PR merged?

@@ -0,0 +1 @@
fixed the Table background color when inverted and basic active at same time @lord2anil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fixed the Table background color when inverted and basic active at same time @lord2anil
Fixed the table background color when its `inverted` and `basic` styles are active at the same time. @lord2anil

@lord2anil
Copy link
Contributor Author

Thanks for the feedback. Due to time constraints, I cannot implement the changes right now.

@ichim-david ichim-david added the Abandoned PRs that are abandoned and in a stale state label Aug 12, 2024
@ichim-david
Copy link
Member

The fix isn't what is needed. Due to the time constraints of the author I am closing this pull request, we can open a new one with the solution proposed by @JeffersonBledsoe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
99 tag: UX Accessibility Accessibility issues Abandoned PRs that are abandoned and in a stale state GSOC-input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table block: "minimalistic design" doesn't work together with "table color inverted"
7 participants