Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact to v4 #6253

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

stevepiercy
Copy link
Collaborator

@stevepiercy stevepiercy commented Aug 13, 2024

@stevepiercy
Copy link
Collaborator Author

I restarted the same 5 failed jobs that failed in #6250.

Here's an example of the failed command.

/usr/bin/make start-test-acceptance-webserver-seamless
/opt/hostedtoolcache/node/18.20.4/x64/bin/npx wait-on --httpTimeout 20000 http-get://127.0.0.1:55001/plone http://127.0.0.1:3000/ http://localhost
/etc/bash.bashrc: line 7: PS1: unbound variable
/etc/bash.bashrc: line 7: PS1: unbound variable
/etc/bash.bashrc: line 7: PS1: unbound variable
/etc/bash.bashrc: line 7: PS1: unbound variable
/etc/bash.bashrc: line 7: PS1: unbound variable
/etc/bash.bashrc: line 7: PS1: unbound variable
/etc/bash.bashrc: line 1: docker-compose: command not found
make: *** [Makefile:267: start-test-acceptance-webserver-seamless] Error 127
/home/runner/work/_actions/cypress-io/github-action/v6/dist/index.js:[39](https://github.com/plone/volto/actions/runs/10375646984/job/28733005594?pr=6253#step:5:40)00
                error = new Error(`The process '${this.toolPath}' failed with exit code ${this.processExitCode}`);
                        ^

Error: The process '/usr/bin/make' failed with exit code 2

I have no clue how to figure out how to start the server correctly. Help!

@davisagli
Copy link
Member

@stevepiercy docker-compose is deprecated and needs to be replaced with docker compose. I did this already on main and the 16.x.x branch, but missed 17.x.x

@stevepiercy
Copy link
Collaborator Author

@davisagli thanks, gotta run, will do tonight.

news/6253.internal Outdated Show resolved Hide resolved
Copy link
Member

@ichim-david ichim-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx guys it's getting hard to maintain 3 branches with fixes :)

@davisagli davisagli merged commit 2ea6a1b into 17.x.x Aug 14, 2024
47 checks passed
@davisagli davisagli deleted the 17.x.x-bump-actions/upload-artifact-v4 branch August 14, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants