improve link integrity popup #6516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
giuliaghisini
changed the title
stevepiercy
requested changes
Dec 6, 2024
stevepiercy
approved these changes
Dec 6, 2024
|
@giuliaghisini we merged #6509 so now importing from barrel files in core is not allowed anymore, so expect some ESlint failures. Could you please update the PR accordingly? Thanks! |
pnicolli
reviewed
Dec 9, 2024
packages/volto/.env.local
Outdated
There was a problem hiding this comment.
Remove this file (maybe we should gitignore *.local files? @sneridagh )
davisagli
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed and improved link integrity popup when deleting item/items from folder contents.
Moved all code in a separate component 'ContentsDeleteModal'.
Added loader when loading references. If the call to @linkintegrity took a long time to load, it wasn't clear to the user that it was checking for broken references:
If only one item is selected to delete, it will display all the possibile broken references in a table, instead in a list. In the last column could be more than one reference:
If more than one item is selected to delete, it will not display the possibile broken references, but only the number, because it will be a very long list (It worked like that before too):
