1024 is max cli length if windows tries to update, auto restart

[ayjayt]

windows uses a microsoft function to restart after update, and you can't have cli longer than 1024

its rare, not much we can do

[ayjayt]

So, sometimes window's chrome will auto-update and try to restart. First of all:

This restart in any context immediately prompts a failure because choreographer only sees windows closing down and doesn't realize it's going to restart.

This is somewhat bad no matter what because I'm not sure we actually have a mechanism to catch the process on the restart. I'm not sure.

We probably we have to let it fail and warn the user, or we have to test to see if we have the restart. I don't know how to repeat this, I don't know how to force the update. Right now, github's runners are using an image that all force auto update.

The issue is again, after this autorestart, I'm not sure we have the same process id. Maybe we do. Maybe looking at windows https://learn.microsoft.com/en-us/windows/win32/recovery/registering-for-application-restart will let us know.

On the other hand, we don't seem to have this problem if we use our local downloads.

Now, with that same windows application, we are limited in the amount of cli tags we can use. Because that function only allows CLI commands of 1024 characters. So even if we DO autorestart, if we want to use the original CLI command set, we have to prepare that the autorestart will FAIL and we do the restart manually.

This is actually super convenient! I want to guarentee that autorestart fails. I wish I could test for it. So there are no zombie processes, only the ones that we start.