Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble appears during escalation when ticket is not validated #239

Open
Windayz opened this issue Sep 4, 2024 · 11 comments
Open

Bubble appears during escalation when ticket is not validated #239

Windayz opened this issue Sep 4, 2024 · 11 comments

Comments

@Windayz
Copy link

Windayz commented Sep 4, 2024

Hello,

Basically, I've just noticed that when a technician escalates the ticket to a group and a mandatory field is not filled in and he saves, it throws a GLPI error (which is normal).
But the “escalate to...” bubble still appears.

image

It's not a major problem, but it's worth pointing out :)

I would have liked to know if it was also possible to implement the possibility of integrating the plugin on one entity, but not another.
Indeed, on an entity that doesn't have a group, the button doesn't appear.
But I have an entity with a single group that doesn't need the plugin, but for this one, it's still displayed.

Thanks :)

@stonebuzz
Copy link
Contributor

Hi @Windayz

can you try this

#240

@Windayz
Copy link
Author

Windayz commented Sep 4, 2024

I've just tried it with the patch and no, it's still the same.

@stonebuzz
Copy link
Contributor

How do you climb :

  • via the history
  • via the list of actors (assigned)

@Windayz
Copy link
Author

Windayz commented Sep 4, 2024

via the list of players

@stonebuzz
Copy link
Contributor

I don't reproduce,

I have a ticket assigned to group A with the location field mandatory but not filled in.

If I climb to the group B (via the history or the list of actors)

the plugin does not perform the escalation because the ticket is incomplete

@Windayz
Copy link
Author

Windayz commented Sep 4, 2024

The technician is part of the N2 group, he wants to send it to N3. On the ticket, he sets the group to N3, but the category, which is mandatory, is not entered.
He clicks on “save” but an error message appears saying that the category is missing, so nothing is saved, but the balloon “Escalade vers le groupe Informatique N3” appears anyway.

@stonebuzz
Copy link
Contributor

I definitely do not reproduce

Can you check that you have applied the patch correctly?

Can you reset your browser's cache and glpi's cache?

php bin/console cache:clear

and retry

@Windayz
Copy link
Author

Windayz commented Sep 4, 2024

It still does, but never mind, it's not a big deal.

@BorisNovg
Copy link

Testing on a test virtual machine - I make a copy of the main server in a separate isolated network segment. GLPI 10.0.15.
I try to change the group from Group1 to Group2 by selecting another group (Group2) in the "Assigned to" field and clicking Save (before that, the mandatory Category field was assigned an "empty" value = 0 in a third-party database editor).


Installing last MASTER escalade version - pluginsGLPI/escalade at 21f9e5e 20240903 Download ZIP
The problem described in this request is reproduced, the test result - the yellow bar "Escalation to the group Group2" was created.

Installing the escalade version with your suggested patch - stonebuzz/escalade at ef8f919 20240904 Download ZIP
The problem described in this request is reproduced, the test result - the yellow bar "Escalation to the group Group1." was created.


The differences in the results are that instead of "Escalation to the group Group2", the yellow bar with the name of group 1 was created! This is certainly better than the erroneous option "Escalation to the group Group2", but I would like the yellow bar not to appear at all, since there was no escalation in fact.

@andrepetinga
Copy link

andrepetinga commented Sep 13, 2024

Hello @stonebuzz.
Just installed the 2.9.9 version, and the problem is also happening here...

1. Tried to escalate without Category, using the Escalate Button:

image

Private message added, but no escalation happened.

2. Tried to escalate without Category, using the Group search textbox:

image

3. Tried to escalate without Category, using escalation history:

image

@andrepetinga
Copy link

andrepetinga commented Sep 13, 2024

Additional note: Just tested on another installation, using 2.9.6 and the problem DID NOT occurred when using the search textbox!

If I try to escalate using Escalate button, the private message is added, and no Error is thrown...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants