Fix ola disabling after esaclation #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebuzz
requested changes
Dec 11, 2024
front/ticket.form.php
Outdated
| @@ -86,7 +86,8 @@ | |||
| // Sanitize before merging with $_POST['comment'] which is already sanitized | |||
| 'content' => Sanitizer::sanitize( | |||
| '<p><i>' . sprintf(__('Escalation to the group %s.', 'escalade'), Sanitizer::unsanitize($group->getName())) . '</i></p><hr />' | |||
| ) . $_POST['comment'] | |||
| ) . $_POST['comment'], | |||
| '_do_not_compute_takeintoaccount' => true | |||
There was a problem hiding this comment.
A dedicated option should be creating from config page to compute or not TTO after escalation, because actually TTO is computed (and the community never complains).
There was a problem hiding this comment.
Yes, an option that will have to take into account that it will only work with a certain version of GLPI (probably 10.0.18).
|
Can you ask the customer to test (with GLPI PR too)? |
Rom1-B
requested changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Passing the _do_not_compute_takeintoaccount option at the end of a task so as not to trigger the end of SLA / OLA TTOs
Screenshots (if appropriate):