Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ola disabling after esaclation #268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −5
Open

Fix ola disabling after esaclation #268

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
731ba1c
Fix ola disabling after esaclation
Lainow Dec 10, 2024
1707c87
Add do not compute in config
Lainow Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion front/ticket.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@
// Sanitize before merging with $_POST['comment'] which is already sanitized
'content' => Sanitizer::sanitize(
'<p><i>' . sprintf(__('Escalation to the group %s.', 'escalade'), Sanitizer::unsanitize($group->getName())) . '</i></p><hr />'
) . $_POST['comment']
) . $_POST['comment'],
'_do_not_compute_takeintoaccount' => true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dedicated option should be creating from config page to compute or not TTO after escalation, because actually TTO is computed (and the community never complains).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, an option that will have to take into account that it will only work with a certain version of GLPI (probably 10.0.18).

]);
}

Expand Down
7 changes: 5 additions & 2 deletions inc/ticket.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ public static function AssignFirstGroupOnSolve(CommonDBTM $item)
'_no_reopen' => true, //prevent reopening ticket
'state' => Planning::INFO,
'content' => __("Solution provided, back to the group", "escalade") . " " .
$group->getName()
$group->getName(),
'_do_not_compute_takeintoaccount' => true
]);
}
}
Expand Down Expand Up @@ -277,7 +278,8 @@ public static function AssignLastGroupOnRejectedSolution(CommonDBTM $item)
'is_private' => true,
'state' => Planning::INFO,
'content' => __("Solution rejected, return to the group", "escalade") . " " .
$group->getName()
$group->getName(),
'_do_not_compute_takeintoaccount' => true
]);
}

Expand Down Expand Up @@ -381,6 +383,7 @@ public static function addHistoryOnAddGroup(CommonDBTM $item)
'is_private' => true,
'state' => Planning::INFO,
'content' => Toolbox::addslashes_deep(sprintf(__("Escalation to the group %s.", "escalade"), $group->getName())),
'_do_not_compute_takeintoaccount' => true
]);
}

Expand Down
Loading