Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public key compressed twice #14

Open
0xbok opened this issue May 8, 2023 · 0 comments · May be fixed by #77
Open

Public key compressed twice #14

0xbok opened this issue May 8, 2023 · 0 comments · May be fixed by #77
Labels
enhancement New feature or request

Comments

@0xbok
Copy link

0xbok commented May 8, 2023

Context: verify_nullifier.circom#L214-L219, verify_nullifier.circom#L72

Public key is compressed twice which results in more constraints than required.

Recommendation: Use the compressed public key for calculating the hash for c, although it makes the code complicated.
@RajeshRk18 RajeshRk18 linked a pull request Nov 18, 2023 that will close this issue
Open
@Divide-By-0 Divide-By-0 added the enhancement New feature or request label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
PLUME Planning
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: public key compression RajeshRk18/zk-nullifier-sig
2 participants
@0xbok @Divide-By-0