-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce DST specific for the protocol! #72
Comments
I agree in this case. Let's standardize a DST! |
Maybe I code particularly bad today, but I finished the implementation to the fine level and started to make the test for it. And that gave me hard time. The bottom line is that while inputs checked out (comparing bigints isn't fun) the signature didn't, since I checked that <./javascript> and So I have the idea to unfold deeper, and while I'm there to choose own DST, then write down new test data using it. Basically that would affect everything. %) |
@Divide-By-0 |
Current used DST is taken from the example, so it will collide with other projects which didn't introduce their own DST, which defies its purpose. I see it as quite a priority since if it won't be done until people start to use the thing it will be quite painful to change as it's not backward compatible in no way.
On the other hand there's quite an amount of tests alignment and small modifications due to change of the DST to proper one. Though not a horrific amount.
So the choice is better be done once and never changed, so it worth to put some effort in it. While it should be done in reasonable time. Obvious step is to start the string with "PLUME", and maybe it would be enough to be aligned with usual string, maybe some more information is nice to put there. Too long string bring small burden, btw.
PS Sorry for brevity, am writing in hurry; hope to edit for better readability, or clarify anything in discussion.
The text was updated successfully, but these errors were encountered: