Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use process group signal handling to reach past the shell #1126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 8, 2024

  1. Use process group signal handling to reach past the shell

    Spawn processes is their own process group and then signal the
    process group intstead of just the process we spawned to ensure
    the signals also reach any subprocesses started by the process we
    spawned (which is always the case as we are wrapping all our
    processes spawning with "/bin/sh -c ...").
    
    This make sending SIGINT work again, so revert back to that instead
    of SIGKILL. The reason SIGINT wasn't working was the shell logic
    is that this is expected to be sent to the process group, so it
    doesn't need to pass it along or anything. See the bash signals
    documentation page for more details
    
    https://www.gnu.org/software/bash/manual/html_node/Signals.html
    twhitehead committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a022e79 View commit details
    Browse the repository at this point in the history