Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed pub-sub not pulling its weight #245

Closed
lewisjkl opened this issue Feb 7, 2020 · 0 comments · Fixed by #246
Closed

Distributed pub-sub not pulling its weight #245

lewisjkl opened this issue Feb 7, 2020 · 0 comments · Fixed by #246
Assignees

Comments

@lewisjkl
Copy link
Contributor

lewisjkl commented Feb 7, 2020

From all that I can tell, we are not utilizing the distributed pub-sub (from akka-clustering) for very much. My assessment leads me to believe that the only spot where we are currently using it is when a topic is created. If this is the case then it really is not saving us anything. Topic creation is few-and-far-between. The main application flow doesn't even take advantage of this functionality (and I don't really think it should either). I think we should get rid of the distributed pub-sub. This would also allow us to remove akka-clustering and dependence from Consul.

Before doing this, we need to validate that my theory is true:

  • The only time that the pub-sub is used is on topic creation.

If it is used elsewhere then we should discuss about whether or not those other cases are needed.

It is worth noting that the akka-management dependency is currently blocking us by not being on the latest version of jackson-fasterxml. This is a dependency that confluent is using for several of their libraries and they are on a newer version of it. This is what originally got me going down this path, but I think in any case it would be good to reduce the complexity here.

@bretrbs bretrbs linked a pull request Feb 10, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants