bounty: determine/fix underconstrained variables in two templates

[brunny-eth]

Bounty description

Address, explain, and, if necessary, fix underconstrained variables in the parser-attestor repo's circuits, specifically in the Contains operator, IsEqualArray, and the state sum variable.

Implementation requirements
For each of the following, you must provide an example of malicious proof is before making any changes in the code!

• underconstrained: accum in Contains operator #34
  • As necessary, implement a rolling constraint on every loop iteration to ensure the sum is being accumulated correctly
• underconstrained: accum in IsEqualArray #35
  • As necessary, implement a rolling constraint on every loop iteration to ensure the sum is being accumulated correctly
• General requirements for completion:
  • Update existing tests to cover new constraints
  • Ensure that circuits still compile and generate valid proofs after adding new constraints

Resources

Circom Documentation
Comments on underconstrained variables

Criteria

Bounties will be rewarded based on the following criteria:

1. Correctness and security: A thorough review of the implementation should convince our team that they are correct and secure, with all requirements met.
2. Code clarity and quality: Succinct, easy-to-follow code with appropriate naming conventions. Utilize Rust’s type system for flexibility and security (e.g., compile-time checks where possible), and avoid external crates. Optimizations should be a lower priority than clarity, but can be included behind a feature flag as a bonus.
3. Documentation quality: Provide comprehensive README’s, Cargo docs, and inline comments where code itself is not self-explanatory. Prioritize clarity and readability.

[aybanda]

@brunny-eth
I'm interested in solving this, can you assign this to me?

[Autoparallel]

@brunny-eth I'm interested in solving this, can you assign this to me?

I'm on it :)

[brunny-eth]

all yours @aybanda. let us know when its ready for a review, we'll check back in a few days to see if you've made some progress 😄

[aybanda]

Working my way through will update you on the progress as early as possible

[brunny-eth]

hey @aybanda, make any progress here? if not, we'll open it up to others that might be interested. let me know what you're thinking