Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release-plz is not working correctly #175

Closed
0xJepsen opened this issue Dec 19, 2024 · 3 comments · Fixed by #176
Closed

chore: Release-plz is not working correctly #175

0xJepsen opened this issue Dec 19, 2024 · 3 comments · Fixed by #176
Labels
bug 🐛 Something isn't working ci/cd 🔄 Changes to CI/CD pipeline

Comments

@0xJepsen
Copy link
Contributor

Currently whenever a new change is merged into main release-plz opens a PR setting the version to 0.1.0

The desired behavior is that it will detect the version in the main branch and it's pr will bump the version to the next minor release and amend changes to the change log from the last time it was merged in.

@0xJepsen 0xJepsen added ci/cd 🔄 Changes to CI/CD pipeline bug 🐛 Something isn't working labels Dec 19, 2024
@Autoparallel
Copy link
Contributor

This isn't really unintended. The crate isn't released!! It can't find a version to compare against. We just need to release the crate.

@0xJepsen
Copy link
Contributor Author

That true but it should still be able to compare semver on main when the publish flag is set to false right?

@Autoparallel
Copy link
Contributor

No, what will it semver against? Semver is a different check entirely than release-plz, though release-plz uses cargo-semver prior to releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working ci/cd 🔄 Changes to CI/CD pipeline
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants