Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/chart api #13

Open
wants to merge 2 commits into
base: feat/multichain
Choose a base branch
from
Open

Refactor/chart api #13

wants to merge 2 commits into from

Conversation

envin3
Copy link
Contributor

@envin3 envin3 commented Oct 30, 2023

No description provided.

@envin3 envin3 requested a review from oliviera9 October 30, 2023 16:11
@@ -1,7 +1,7 @@
{
"name": "dao-v2-ui",
"version": "0.1.0",
"lockfileVersion": 2,
"lockfileVersion": 3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep attention here. You are probably using a newer version of node than the one used in the project. Try to check if there's a nvmrc and stick to that version. I wouldn't modify the lock file in this PR.

Copy link
Contributor

@oliviera9 oliviera9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it more. The correctedData calculation was obscure. Anyway, check the package-lock.json comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants