Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eos): fix block submission for v2 EOS nodes following the spring hardfork #36

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix(eos): fix block submission for v2 EOS nodes following the spring hardfork #36

wants to merge 9 commits into from

Conversation

ubordignon
Copy link
Contributor

No description provided.

@ubordignon ubordignon requested review from envin3 and gitmp01 October 8, 2024 09:50
@ubordignon ubordignon force-pushed the v2-fix-spring-hardfork-block-submission branch from 50f38c2 to 4be2637 Compare October 8, 2024 13:15
@ubordignon ubordignon force-pushed the v2-fix-spring-hardfork-block-submission branch from 4be2637 to 9f0138b Compare October 8, 2024 13:37
gitmp01
gitmp01 previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@gitmp01 gitmp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got few comments, but looks good overall, well done!

common/eos/src/eos_enclave_state.rs Show resolved Hide resolved
v2_bridges/vanilla_apps/peos-on-int/src/main.rs Show resolved Hide resolved
envin3
envin3 previously approved these changes Oct 8, 2024
View reviewed changes
Copy link

@envin3 envin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubordignon ubordignon dismissed stale reviews from envin3 and gitmp01 via bd28c13 October 8, 2024 15:39
@ubordignon ubordignon force-pushed the v2-fix-spring-hardfork-block-submission branch from 9f0138b to bd28c13 Compare October 8, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitmp01 gitmp01 gitmp01 left review comments

@envin3 envin3 envin3 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ubordignon @envin3 @gitmp01