Few improvements #11

gitmp01 · 2024-04-03T11:51:49Z

Stringify output
Add originChainId field & actualAmount field to the nodeOperatorFeeSinkTokenBalances output

… operators fees info

gskapka

LGTM to me, have approved, though there is a suggestion which I strongly encourage taking, since it'll make life much easier for all concerned.

lib/get-router-state.js

gskapka

LGTM! Much easier now for anyone dealing with the fees.

gitmp01 added 2 commits April 2, 2024 19:03

chore(get-router-state): stringify final json for output processings

02cd442

chore(get-router-state): add actualAmount & originChainId to node…

69402c8

… operators fees info

gitmp01 requested a review from gskapka April 3, 2024 11:52

gskapka previously approved these changes Apr 3, 2024

View reviewed changes

lib/get-router-state.js Show resolved Hide resolved

chore(get-router-state): add human readable chain id

c8a565c

gitmp01 dismissed gskapka’s stale review via c8a565c April 3, 2024 13:22

gitmp01 added 2 commits April 3, 2024 15:24

fix(hardhat.config.js): require dotenv

21d2802

chore(package.json): bump minor

5cd4cbc

gskapka self-requested a review April 3, 2024 14:27

gskapka reviewed Apr 3, 2024

View reviewed changes

gskapka requested review from gskapka April 3, 2024 14:36

gskapka approved these changes Apr 3, 2024

View reviewed changes

gitmp01 merged commit 9d7cd47 into master Apr 3, 2024
1 check passed

gitmp01 deleted the fix/output branch April 3, 2024 15:42

Provide feedback