Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DenseSLR1(ThirdOrderSpherical) has a NaN vector-Jacobian product #500

Open
pnkraemer opened this issue Apr 5, 2023 · 2 comments
Open

DenseSLR1(ThirdOrderSpherical) has a NaN vector-Jacobian product #500

pnkraemer opened this issue Apr 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@pnkraemer
Copy link
Owner

For some reason.
Weirdly, UnscentedTransform and GaussHermite work just fine.
When setting UnscentedTransform(r=0.) (which recovers the third-order spherical rule), the errors re-emerge.
Something about the linearise_slr1/ThirdOrderSpherical combination yields NaN gradients.

For the moment, until this is fixed, users should choose UnscentedTransform instead.

Related: #470
@pnkraemer pnkraemer added the bug Something isn't working label Apr 5, 2023
@pnkraemer pnkraemer mentioned this issue Apr 5, 2023
Merged
@pnkraemer
Copy link
Owner Author

It turns out that the JVP kind of works, but the tests are very flaky. Therefore we skip them (#503) until this bug has been resolved for good.

@pnkraemer pnkraemer mentioned this issue Oct 23, 2023
Closed
@pnkraemer
Copy link
Owner Author

It might have been resolved by the linked PR. Worth checking at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pnkraemer