Add possibility to add custom additional step #404
Conversation
…in red markdown (pnp#382) ## 🎯 Aim Adding the errormessage as output in the chat response ## 📷 Result  ## ✅ What was done - [X] Added error response in red markdown to `PromptHandlers` ## 🔗 Related issue Closes: pnp#376
…kit, Closes pnp#348 (pnp#383) ## 🎯 Aim Adds 'Set Form Customizer' command to the SharePoint Framework Toolkit, to set the view, edit or new form with a form customizer ## 📷 Result https://github.com/user-attachments/assets/1ac118ed-ad4b-44bb-946f-94c228aa0d81 ## ✅ What was done - [X] Add action to set the view, edit & new form with a form customizer ## 🔗 Related issue Closes pnp#348
…user guidance, Closes pnp#286 (pnp#384) ## 🎯 Aim Includes check output window for CLI Actions ## 📷 Result  ## ✅ What was done - [X] Added check output window for CLI Actions ## 🔗 Related issue Closes pnp#286
## 🎯 Aim Allows to install/uninstall an app on a specified site collection using a action in the app catalog app list view ## 📷 Result  ## ✅ What was done - [X] Install/Uninstall actions added to both tenant and site collection app catalog apps - [X] Prompts for relative site URL when actions triggerred in tenant app catalog apps. - [X] Requires confirmation before uninstalling app. ## 🔗 Related issue Closes: pnp#350
…elcome view. Closes pnp#334 (pnp#392) ## 🎯 Aim The aim is to update vscode types and approach with latest. Recheck and cleanup what changed. When upgraded vscode we may use latest improvements of how to handle model picking and loading history in chat command. I checked that and unfrotonatly other models than gpt-4o bring totally different responses which are not possible to pars with current logic. Also loading history seems to be lacking some parts we get with current implementation, so those parts are not changed. Lastly I added action to activate SPFx Copilot from welcome view ## 📷 Result  ## ✅ What was done - [X] updated vscode engine and typing to latest - [X] refactor auth provider - [X] rechecked current chat logic implementation - [X] added copilot action to welcome view ## 🔗 Related Issue Closes: pnp#334
## 🎯 Aim The aim is to fix wrong warning message regarding Node version ## 📷 Result  ## ✅ What was done - [X] Fixup in warning message ## 🔗 Related issue Closes: pnp#395
|
I love the ID of this PR 😄 404 |
|
It would be my PR that gets this 404 ID. |
There was a problem hiding this comment.
@ervingayle Awesome work so far 👏👏👏
I had to stop my review as I noticed that you pushed commits to this branch that are part of a different issue you are assigned to. I think the problem is you were working on your dev branch instead of separate branch based on dev that was created only for this feature.
We should clean this up before we proceed. Best approach would be to create new branches and cherry-pick to them only the commits that are required for issue #217 and close this PR without merging and reopen an another PR from a different branch then this one.
I added more context in the issue #325 which might be helpful how to get around that
| "spfx-toolkit.projectCustomSteps": { | ||
| "title": "Additional Custom Steps", | ||
| "type": "string", | ||
| "default": "[\n {\n \"label\": \"PnP JS SharePoint\",\n \"command\": \"npm install @pnp/sp\"\n },\n {\n \"label\": \"PnP React Reusable Controls\",\n \"command\": \"npm install ....\"\n }\n]", |
There was a problem hiding this comment.
I would say by default it should be empty and we should not prefill this setting with any custom additional step
There was a problem hiding this comment.
I thought that a sample should be provided by default even if it is the sample that was posted in the initial issue. However, I will follow your suggestion
There was a problem hiding this comment.
maybe we could add some link to wiki with more guidance in the label. This is the settings value which I guess will fail if we have .... in it. I guess it wont be valid right
| // eslint-disable-next-line no-console | ||
| console.log(jsonArray.length); |
There was a problem hiding this comment.
we should avoid console logs in code at all time. If we want to add additional logging we should use logger for that
src/panels/CommandPanel.ts
Outdated
| } else { | ||
| tenantWideExtensionsList.push(new ActionTreeItem('No extension found', '')); | ||
| } | ||
| const tenantWideExtensionsNode = new ActionTreeItem('Tenant-wide Extensions', '', { name: 'spo-app-list', custom: true }, TreeItemCollapsibleState.Collapsed, undefined, undefined, 'sp-app-catalog-tenant-wide-extensions', undefined, |
There was a problem hiding this comment.
wooops! Seems like those changes should not be part of this PR as they are not needed for this issue.
We should clean this up before we proceed.
Co-authored-by: Adam Wójcik <[email protected]>
Co-authored-by: Adam Wójcik <[email protected]>
|
@ervingayle I will close this PR and let's open it up again once we managed to sort out the git history problems |
🎯 Aim
This PR implements functionality that allows for custom npm packages to be installed as part of the scaffolding project setup.
📷 Result
✅ What was done
🔗 Related issue
Closes: #217