Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dockerfile for project contributors #978

Merged
merged 5 commits into from
Sep 1, 2024
Merged

Conversation

zkkv
Copy link
Contributor

@zkkv zkkv commented Aug 30, 2024

Add a Dockerfile to make it easier to contribute to the project with Docker

zkkv added 2 commits August 31, 2024 00:57
Add a Dockerfile to make it easier to contribute the project with Docker
Poac run command couldn't be used without make, g++ and clang
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! I think it makes more sense to use dev containers for development purpose, i.e., .devcontainer/Dockerfile along with .devcontainer/devcontainer.json. What do you think?

@zkkv
Copy link
Contributor Author

zkkv commented Aug 31, 2024

I think it can be useful, but as far as I understand it's VSCode-specific. I don't use VSCode, so I cannot reliably add this.

I would still keep the Dockerfile in the root directory because it's editor-agnostic.

@ken-matsui
Copy link
Member

Sounds good. Can you please add the following GH action workflow to just test docker build? (please tweak if needed)

.github/workflows/docker.yml

name: Docker

on:
  push:
    branches: [main]
  pull_request:

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
      - name: Checkout code
        uses: actions/checkout@v4

      - name: Build Docker image
        run: docker build .

@zkkv zkkv force-pushed the dockerfile branch 2 times, most recently from 45db41d to 73de0a4 Compare September 1, 2024 14:08
@zkkv
Copy link
Contributor Author

zkkv commented Sep 1, 2024

I added an extra step that creates a container from the built image. Feel free to squash my commits, if you think it looks good.

Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for your time to work on this!

@ken-matsui ken-matsui merged commit ecb95b3 into cabinpkg:main Sep 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants