-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Dockerfile for project contributors #978
Conversation
Add a Dockerfile to make it easier to contribute the project with Docker
Poac run command couldn't be used without make, g++ and clang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! I think it makes more sense to use dev containers for development purpose, i.e., .devcontainer/Dockerfile
along with .devcontainer/devcontainer.json
. What do you think?
I think it can be useful, but as far as I understand it's VSCode-specific. I don't use VSCode, so I cannot reliably add this. I would still keep the Dockerfile in the root directory because it's editor-agnostic. |
Sounds good. Can you please add the following GH action workflow to just test docker build? (please tweak if needed)
name: Docker
on:
push:
branches: [main]
pull_request:
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Build Docker image
run: docker build . |
45db41d
to
73de0a4
Compare
I added an extra step that creates a container from the built image. Feel free to squash my commits, if you think it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you for your time to work on this!
Add a Dockerfile to make it easier to contribute to the project with Docker