Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t allow calling reveal in release builds #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don’t allow calling reveal in release builds #66

wants to merge 1 commit into from

Commits on Dec 2, 2018

  1. Don’t allow calling reveal in release builds 

    Some structs have a `reveal` method, which deliberately leaks secret
information for debug builds.  There is no legitimate reason to use
them for anything other than debugging, and no uses at all in any of the
other codebases I am working on.

To ensure that no new uses of this method are added, make this method
only available when debug assertions are turned on.  This ensures that
any attempts to uses this method will break release builds, and thus be
quickly discovered.
    @DemiMarie
    DemiMarie committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    5b57f59 View commit details
    Browse the repository at this point in the history