Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lastest steep and remove Grepx definition #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hoshinotsuyoshi
Copy link

@hoshinotsuyoshi hoshinotsuyoshi commented Oct 18, 2023

PR for #4

Steps to reproduce the problem

#4

Steps to reproduce the problem

  1. Check out the https://github.com/ydah/sandbox-rubocop-grep
  2. Run bundle install.
  3. Run bundle exec rubocop.

Steps to verify this pull request

  1. Check out the https://github.com/ydah/sandbox-rubocop-grep
  2. Install this branch :
--- a/Gemfile
+++ b/Gemfile
@@ -1,6 +1,7 @@
 # frozen_string_literal: true

 source 'https://rubygems.org'
+git_source(:github) { |repo| "https://github.com/#{repo}.git" }

 gem 'rubocop'
-gem 'rubocop-grep'
+gem 'rubocop-grep', github: 'hoshinotsuyoshi/rubocop-grep', branch: 'bundle-update-steep-and-remove-grepx'
  1. Run bundle exec rubocop.
$ bundle exec rubocop --cache=false -d

...snip....


Offenses:

target.rb:3:1: C: Grep/Grep: Do not refer ENV directly.
ENV
^^^

2 files inspected, 1 offense detected
Finished in 0.07266599999275059 seconds

@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as ready for review October 18, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant