Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 260 #261

Merged
merged 10 commits into from
May 2, 2024
Merged

Feature/issue 260 #261

merged 10 commits into from
May 2, 2024

Conversation

nlenssen2013
Copy link
Collaborator

Github Issue: #260

Description

Add function in gpm_cleanup.py module to handle collections without a subset-able time variable

Overview of work done

utilize the datetime.datetime library to convert variables: year, month, day of month, hour, minute, sec to a single seconds since Jan 6th 1980.

Overview of verification done

Send test file in compute time var function

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • [x ] Linted
  • [x ] Updated unit tests
  • [x ] Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@nlenssen2013 nlenssen2013 marked this pull request as ready for review May 1, 2024 18:40
@jamesfwood jamesfwood merged commit 71defcf into develop May 2, 2024
2 checks passed
@jamesfwood jamesfwood deleted the feature/issue-260 branch May 2, 2024 16:19
@jamesfwood jamesfwood mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants