Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language issues #2

Open
jazzido opened this issue Jun 24, 2013 · 12 comments
Open

Language issues #2

jazzido opened this issue Jun 24, 2013 · 12 comments

Comments

@jazzido
Copy link

jazzido commented Jun 24, 2013

Hey,

I just wanted to point out that in order to ease adoption and collaboration from developers outside of Poderopedia, variable names, method names and comments should be in english.

For instance:

def sugerir_persona() should be def suggest_person()

Just my two cents.

Congratulations on the release!

@pudo
Copy link

pudo commented Jun 24, 2013

+1

@rampmaster
Copy link
Contributor

Is it possible to send a pull request with the changes and proposed name?
Thanks

@pudo
Copy link

pudo commented Jun 24, 2013

Hm, this affects literally the entire code base and would require a spanish speaker, I think its a larger, strategic decision for the project?

@jazzido
Copy link
Author

jazzido commented Jun 24, 2013

I agree with @pudo, such an effort should come from the mantainers. Almost every file would be modified.

@ghost ghost assigned juaneduardo Jun 28, 2013
@miguelpaz
Copy link
Member

@jazzido and @pudo we are on it. We need to map all language names, variable names, method names and comments to change. But since we must start on what adds more value, which are the critical parts that need to be changed according to you?

@pudo
Copy link

pudo commented Jul 2, 2013

Thanks for the quick response. For contributors, it may be useful to start with file names for quicker navigation as well as the database model, the skeleton of the application.

@miguelpaz
Copy link
Member

We are on it @pudo and @jazzido. @juaneduardo is changing names as I write this. For broader conversation we have a mailing list https://groups.google.com/forum/?hl=es#!forum/poderopedia-users

@juaneduardo
Copy link
Member

i changes the functions names in controllers... for the admin application

@miguelpaz
Copy link
Member

@pudo @jazzido changes were made already. Care to comment or review?

@vsusarla
Copy link

Hi! I am trying to adopot poderopedia to build a website. I just want to know if there is anyway to launch an english version of the website. I f so what changes need to be made in which files?

@miguelpaz
Copy link
Member

@vsusarla hey, yes there is. @juaneduardo can help you with that. There is a translation tool for it. We need to add it. Please follow up on this opened issue: #13

@vsusarla
Copy link

Thanks a lot @miguelpaz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants