Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Istanbul Fork? #530

Open
lautarodragan opened this issue Oct 9, 2018 · 2 comments
Open

Istanbul Fork? #530

lautarodragan opened this issue Oct 9, 2018 · 2 comments
Labels
testing

Comments

@lautarodragan
Copy link
Member

Our README reads:

Note: We are using our own forks of nyc and istanbul-lib-instrument in order to add better support for TypeScript. We intend to contribute our forks back to nyc and istanbul-lib-instrument in order to make our solution available to the entire community. You can follow the issues in this PR, and check the new PRs for istanbul-lib-instrument.

Now that istanbuljs/istanbuljs#205 is merged and istanbuljs/istanbuljs#204 closed, is this still so? Do we need to update our dependencies or documentation?

@wzalazar
@lautarodragan lautarodragan added this to the Mainnet-launch milestone Oct 9, 2018
@wzalazar
Copy link
Contributor

wzalazar commented Oct 9, 2018

@lautarodragan we have to create a PR in https://github.com/istanbuljs/nyc for setting the new option

@geoffturk geoffturk modified the milestones: Mainnet-launch, PML2, PML1 Dec 5, 2018
@wzalazar
Copy link
Contributor

I created this PR istanbuljs/nyc#948 related to this issue, but I have a problem with CI, I'm waiting for the reply of the core developers

@lautarodragan lautarodragan removed this from the PML1 milestone Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lautarodragan @wzalazar @geoffturk