Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out IPFS class from API/FileController.ts #700

Open
kennylavender opened this issue Oct 31, 2018 · 1 comment
Open

Refactor out IPFS class from API/FileController.ts #700

kennylavender opened this issue Oct 31, 2018 · 1 comment
Labels

Comments

@kennylavender
Copy link
Contributor

API/FileController currently contains its a function that uploads to IPFS, it should be extracted how the other modules have a IPFS class.

@lautarodragan
Copy link
Member

If possible and not too much extra work, it'd be great to stop creating individual versions of IPFS Clients for each module and just have one in Helpers or the separate project you had started. Shouldn't be a ton of work and the benefit would be pretty big.

We could use it in the integration tests, too.

@geoffturk geoffturk added this to the Mainnet-launch milestone Nov 1, 2018
@geoffturk geoffturk modified the milestones: Mainnet-launch, PML1 Nov 12, 2018
@geoffturk geoffturk removed this from the PML1 milestone Nov 29, 2018
@geoffturk geoffturk added ct-z and removed ct-z labels Nov 29, 2018
@geoffturk geoffturk added this to the PML1 milestone Nov 29, 2018
@lautarodragan lautarodragan removed this from the PML1 milestone Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants