-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhantomJS 2.x support? #39
Comments
I'm carefully monitoring phantomjs forums and issues and there are still many problems with phantomjs 2.x and I think that phantomjs 1.9 is better choice for pdf rendering by now. Main issues
I think that the best I can do now is remove the default phantomjs and let the lib user to install and provide the path to phantomjs manually. What you think? |
I think that's a good idea. I was going to recommend making it one of the So allowing the user to manually pull in whatever version of phantomjs they want sounds like a good idea (as long as you still provide information on a version you've tested and recommended). The issue for me is more of an annoyance just trying to keep NPM from constantly complaining about old packages (since the version of phantomjs currently required still uses the deprecated npmconf module). |
I just checked, and it looks like some of the older dependencies like npmconf were removed in the latest 1.x version of the |
What's the status of this issue? |
Yea, there are currently security issues with phantomjs 1.9x. It would be really great, if the default could be updated to use the 2.x version. Thanks! |
regarding the security issues with phantomjs 1.9.x i've made a comment here |
Based on the lack of maintenance over the past couple years and this post it looks to me like PhantomJS is going away at some point (or at least is going to be stagnant). It looks like switching to an alternative (possibly the new headless Chrome mode) would be the best long term solution. I'm sure that will entail a decent amount of work, but as the rest of the javascript ecosystem evolves things will most likely only get harder/buggier trying to stick with PhantomJS. |
yes, exactly. we have plans to make a package that uses Chrome healdess mode with the same use case of this package. (and probably with the same features) 😀 |
Bad news: this doesn't work under nodejs v12.x |
Is there anything blocking this module (or others like phantom-workers) from having the dependency for PhantomJS updated to the 2.x series?
The text was updated successfully, but these errors were encountered: