Fix memory leak due to mirror destructuring. (#20)

* Fix memory leak due to mirror destructuring. * Fix CI
pointfreeco · Jan 28, 2021 · 1aa1bf7 · 1aa1bf7
1 parent 469ef51
commit 1aa1bf7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/Makefile b/Makefile
@@ -10,7 +10,6 @@ test-linux:
 
 test-swift:
 	swift test \
-		--enable-pubgrub-resolver \
 		--enable-test-discovery \
 		--parallel
 

diff --git a/Sources/CasePaths/EnumReflection.swift b/Sources/CasePaths/EnumReflection.swift
@@ -58,13 +58,13 @@ public func extract<Root, Value>(case embed: (Value) -> Root, from root: Root) -
     var path: [String?] = []
     var any: Any = root
 
-    while case let (label?, anyChild)? = Mirror(reflecting: any).children.first {
+    while let child = Mirror(reflecting: any).children.first, let label = child.label {
       path.append(label)
-      path.append(String(describing: type(of: anyChild)))
-      if let child = anyChild as? Value {
+      path.append(String(describing: type(of: child.value)))
+      if let child = child.value as? Value {
         return (path, child)
       }
-      any = anyChild
+      any = child.value
     }
     if MemoryLayout<Value>.size == 0, !isUninhabitedEnum(Value.self) {
       return (["\(root)"], unsafeBitCast((), to: Value.self))