Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

移除 go.mod 中的间接引用 #57

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

WTIFS
Copy link
Contributor

@WTIFS WTIFS commented Sep 8, 2023

Please provide issue(s) of this PR:
Fixes #

早期 polaris-go 的 go.mod 应该是不够完善,这个项目引用 polaris-go 后,把 polaris-go 的引用作为自己的间接引用写入 go.mod 中了。带来一个问题:间接引用的 zap 版本不知为何为 v1.25.0,这个版本的 zap 要求 go 1.19,使用了 any 关键字。而 grpc-go-polaris 以及 polaris-go 目前只要求 go1.15。导致我使用低于 go1.19 的版本时,无法编译

现在 polaris-go 的 go.mod 完善了,在 grpc-go-polaris 的 go.mod 中就不再需要间接引用了

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Config
  • Docs
  • Resolver
  • Performance
  • Monitor and Observability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant