Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to use QT6 (still supports QT5 5.15+) #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

susnux
Copy link

@susnux susnux commented May 2, 2023

This allows to use the current QT version 6 while keeping backwards compatibility with QT5 5.15 or later.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@DavidEGrayson
Copy link
Member

Thanks. I'd like to switch over to Qt 6 and merge this in eventually, but I'll probably have to update the instructions in BUILDING.md and then test building on all the platforms we care about. You wrote "5.15" in the command to find Qt5, but we should probably just remove that, since we expect this to work with a wide variety of Qt5 versions.

@susnux
Copy link
Author

susnux commented May 2, 2023

I can adjust the building instructions as well :)

I think 5.15 was the version that introduced the versionless cmake macros? Took that comment from the qt docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants