Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array Bug in Hashlink target #59

Open
darmie opened this issue Jan 11, 2022 · 1 comment
Open

Array Bug in Hashlink target #59

darmie opened this issue Jan 11, 2022 · 1 comment

Comments

@darmie
Copy link

darmie commented Jan 11, 2022

This line causes a problem

untyped a.length = len;

I fixed it this by removing the length setter for HL target...

#elseif hl
var a = [];
return a;
#else
var a = [];
untyped a.length = len;
return a;
#end

I didn't open a pull request because I haven't done extensive tests beyond my own use case, but please look into this cos it's breaking my library on HL target.

@justin-espedal
Copy link

There’s a PR for this issue. There, length is set with resize instead of not being set at all.

#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants