Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate x/rollup IsSystemTx usage #128

Open
natebeauregard opened this issue Aug 12, 2024 · 2 comments
Open

Investigate x/rollup IsSystemTx usage #128

natebeauregard opened this issue Aug 12, 2024 · 2 comments

Comments

@natebeauregard
Copy link
Collaborator

Investigate the x/rollup module's usage of IsSystemTx and update it if it's not current.

Relevant comment thread: #124 (comment)
https://specs.optimism.io/protocol/regolith/overview.html
@natebeauregard
Copy link
Collaborator Author

@NiloCK Feel free to elaborate on anything in this issue for updating the IsSystemTx usage, I'm not too familiar with what this investigation would entail.

@natebeauregard natebeauregard mentioned this issue Aug 12, 2024
Merged
@AnkushinDaniil
Copy link
Contributor

Canyon includes Regolith updates.
isSystemTx is set to true prior to the Regolith upgrade, and false after and is always false for user deposited transactions.
Optimism doesn't support anything before Canyon.
I think we should change the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@natebeauregard @AnkushinDaniil