Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go get instead of replace directives to downgrade dependencies in monogen #244

Open
Tracked by #227
joshklop opened this issue Oct 4, 2024 · 3 comments
Open
Tracked by #227

Comments

@joshklop
Copy link
Collaborator

joshklop commented Oct 4, 2024

Right now, we downgrade a number of dependencies using replace directives. We should do this using the go command instead of replace directives.

@joshklop joshklop mentioned this issue Oct 4, 2024
@Jesserc
Copy link
Contributor

Jesserc commented Oct 8, 2024

@joshklop please can you expand on this?

@joshklop
Copy link
Collaborator Author

joshklop commented Oct 8, 2024

I think some of the replace directives are unnecessary, like this one:

github.com/btcsuite/btcd/btcec/v2 v2.3.4 => github.com/btcsuite/btcd/btcec/v2 v2.3.2

We should instead use go get to downgrade the package instead. See the gocmd package in the github.com/ignite/cli module for a way to easily use the go command from a Go program.

@pri-3x
Copy link

pri-3x commented Oct 12, 2024

@joshklop PR for this issue: #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants