Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved deposits #309

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Improved deposits #309

merged 3 commits into from
Nov 28, 2024

Commits on Nov 27, 2024

  1. Add EthDepositTx proto

    Previously, we used `repeated bytes` for the type of the deposit transactions in
    `MsgApplyL1Txs`. Unfortunately, this led to arbitrary byte strings unmarshaling
    into the `MsgApplyL1Txs` type. By encapsulating each deposit tx in a separate
    `EthDepositTx` type, we avoid this issue.
    joshklop committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    fe09c24 View commit details
    Browse the repository at this point in the history
  2. Add DepositsTx transaction type

    In preparation for splitting the MsgApplyL1Txs type into multiple messages,
    we add a Cosmos SDK transaction type that will wrap all deposits.
    joshklop committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ec25509 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Split MsgApplyL1Txs into two messages

    MsgSetL1Attributes or MsgApplyUserDeposit
    joshklop committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0859fdc View commit details
    Browse the repository at this point in the history