Fix KeyUsage/KeyUsages #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keyusages, impl from keyusages for attribute, impl from keyusages for extension
…m where it made sense
…ix TryFrom<Extension> for KeyUsages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misread and/or misinterpreted information from RFC5280, describing the KeyUsage extension. This PR properly implements the KeyUsage extension as intended in RFC5280 (closes #28), closes #29, re-exports
derandspkiand makes errors a little nicer.The PR also adds a new example called
ed25519_from_der, which shows how to create a certificate by importing DER encoded bytes.