New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App codegen: remove arg types/interfaces #120

Open

krisbitney opened this issue Oct 19, 2023 · 0 comments

Contributor

krisbitney commented Oct 19, 2023

We can simplify app codegen by removing the Args types.

Current method codegen:

export interface TestImport_Module_Args_anotherMethod {
  arg1: Array<Types.String>;
  arg2: Types.Int32;
}

async anotherMethod(
  args: TestImport_Module_Args_anotherMethod,
  client?: CoreClient,
  env?: Record<string, unknown>,
  uri?: string,
): Promise<InvokeResult<Types.Int32>>

Proposed method codegen:

async anotherMethod(
  arg1: Array<Types.String>,
  arg2: Types.Int32,
  _options: {
    client?: CoreClient,
    env?: Record<string, unknown>,
    uri?: string,
  }
): Promise<InvokeResult<Types.Int32>>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment