Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple small issues and suggestions #35

Open
ocornu opened this issue Dec 11, 2017 · 16 comments
Open

Multiple small issues and suggestions #35

ocornu opened this issue Dec 11, 2017 · 16 comments

Comments

@ocornu
Copy link

ocornu commented Dec 11, 2017

Hi,
I'm running the Google Play version (2.3), so I'm afraid what I'm gonna say next has long been fixed. That's why I'll bundle them in a single ticket here. By the way, I'd love some documentation on how to build this —I've never built an android app before!

  1. Selecting the "Metrics Units" checkbox does not work over app restart (option is selected ok, but metrics units won't show up until you unselect/reselect it in the settings).
  2. When disconnected/reconnected (board power cycle for example), the state of the pads is not updated until you step back on it
  3. Damn, I forgot what it was... Will edit later I guess.

EDIT:
I guess it was a couple suggestions:

  1. Optional speed alert that would play a sound when you go beyond a set speed. Additional safety against high-speed nosedives.
  2. Optional charge alert that would play a sound when you reach a certain level. Would help you stop recharging before 100% when starting from a hilltop.
@ocornu ocornu changed the title Multiple small issues Multiple small issues and suggestions Dec 11, 2017
@ebabel
Copy link
Collaborator

ebabel commented Dec 11, 2017

@ocornu Thanks for this great feedback and suggestions. Will fix asap.

@ebabel
Copy link
Collaborator

ebabel commented Dec 12, 2017

Fixed metric units problem in #36

@ebabel
Copy link
Collaborator

ebabel commented Dec 12, 2017

@kwatkins do we know if the device is plugged in to the charger?
There's an easy way to add a charge alert, which requires the app staying on screen and connected with to the OW. The other way which allows you to turn off your phone and/or use other apps is more complex and would take a while. see #4

@ebabel
Copy link
Collaborator

ebabel commented Dec 12, 2017

@ocornu What sound would you want to hear for the speed alert?

@ocornu
Copy link
Author

ocornu commented Dec 12, 2017

do we know if the device is plugged in to the charger?

Seems so:
image

What sound would you want to hear for the speed alert?

Well, any sound would do, but: good point. :)
Mmh... How about a cop/ambulance siren sound? Something that suggests breaking the speed limit, or getting closer to riding back in an ambulance... :D

@ebabel
Copy link
Collaborator

ebabel commented Dec 12, 2017

@ocornu one of these perhaps? http://soundbible.com/tags-siren.html
maybe the zombie "BRAINS!"

@ocornu
Copy link
Author

ocornu commented Dec 12, 2017

@ebabel lol
Perhaps a shorter version of http://soundbible.com/581-Police-Siren-3.html ?
I like http://soundbible.com/45-Police-Siren.html better, but its licensed for personal use only. :/

@ocornu
Copy link
Author

ocornu commented Dec 12, 2017

For the record; the max speed alert idea comes from OneDan+ on the OW forum: http://community.onewheel.com/topic/7477/customizable-top-speed-warning-please

@ebabel
Copy link
Collaborator

ebabel commented Dec 12, 2017

Thanks for the link, I see there is a lot of interest in this feature! I had forgotten that at one point I really wanted this too.

@kwatkins
Copy link
Collaborator

@ocornu great ideas!

re: getting the charging state @ebabel I just sadly confirmed that flag doesn't set when the OW is charging (deviceStatus.charging). It's always false. You could keep state on the amps added or the battery %, that should work.

@wmaciel
Copy link
Collaborator

wmaciel commented Dec 13, 2017

The official app knows when it is charging, there's gotta be a way to know.

I think having a watch on the battery percentage might not be enough as if you start going downhill and end up "charging" the battery past the set limit you might confuse some people.

Maybe if the speed is also zero we could fire the alarm, but thats a bit contrived, I think.

@ebabel
Copy link
Collaborator

ebabel commented Dec 13, 2017

hmm, for now I'll just always play the sound when the checkbox is checked and the percent is over the user's requested percent. They can turn it off when they're done charging and back on again when they start.
If you guys think of something better let me know.

@ocornu
Copy link
Author

ocornu commented Dec 13, 2017

The official app knows when it is charging, there's gotta be a way to know.

Yeah, bit 13 of the status register (the infamous "status 8192") isn't it?

EDIT: fixed bit nb.

@ocornu
Copy link
Author

ocornu commented Dec 13, 2017

It seems official app is giving status 8196 when full. Is bit 2 a "battery full" flag?

@ebabel
Copy link
Collaborator

ebabel commented Dec 14, 2017

Optional speed alert that would play a sound when you go beyond a set speed. Additional safety against high-speed nosedives.
Optional charge alert that would play a sound when you reach a certain level. Would help you stop recharging before 100% when starting from a hilltop.

Fixed in #38

still need:

When disconnected/reconnected (board power cycle for example), the state of the pads is not updated until you step back on it

@ocornu
Copy link
Author

ocornu commented Dec 15, 2017

Awesome, thanks!
You guys are super reactive, kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants