-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple small issues and suggestions #35
Comments
@ocornu Thanks for this great feedback and suggestions. Will fix asap. |
Fixed metric units problem in #36 |
@kwatkins do we know if the device is plugged in to the charger? |
@ocornu What sound would you want to hear for the speed alert? |
Well, any sound would do, but: good point. :) |
@ocornu one of these perhaps? http://soundbible.com/tags-siren.html |
@ebabel lol |
For the record; the max speed alert idea comes from OneDan+ on the OW forum: http://community.onewheel.com/topic/7477/customizable-top-speed-warning-please |
Thanks for the link, I see there is a lot of interest in this feature! I had forgotten that at one point I really wanted this too. |
The official app knows when it is charging, there's gotta be a way to know. I think having a watch on the battery percentage might not be enough as if you start going downhill and end up "charging" the battery past the set limit you might confuse some people. Maybe if the speed is also zero we could fire the alarm, but thats a bit contrived, I think. |
hmm, for now I'll just always play the sound when the checkbox is checked and the percent is over the user's requested percent. They can turn it off when they're done charging and back on again when they start. |
Yeah, bit 13 of the status register (the infamous "status 8192") isn't it? EDIT: fixed bit nb. |
It seems official app is giving status 8196 when full. Is bit 2 a "battery full" flag? |
Fixed in #38 still need:
|
Awesome, thanks! |
Hi,
I'm running the Google Play version (2.3), so I'm afraid what I'm gonna say next has long been fixed. That's why I'll bundle them in a single ticket here. By the way, I'd love some documentation on how to build this —I've never built an android app before!
EDIT:
I guess it was a couple suggestions:
The text was updated successfully, but these errors were encountered: