Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GParted menu icons illegible in dark theme #80

Open
jacobgkau opened this issue Feb 1, 2021 · 7 comments
Open

GParted menu icons illegible in dark theme #80

jacobgkau opened this issue Feb 1, 2021 · 7 comments
Assignees
Labels
blocked Blocked due to missing required information bug Something isn't working

Comments

@jacobgkau
Copy link
Member

Describe the problem: In GParted, the menu/toolbar icons are nearly illegible due to lack of contrast when using the default Pop Dark GTK theme combined with the default Pop icon theme:
Screenshot from 2021-02-01 13-49-31
Switching to the Adwaita icon theme makes the icons legible:
Screenshot from 2021-02-01 13-49-47

Steps to reproduce:

  1. Open GParted on a freshly-installed Pop!_OS 20.10 system.

Distribution: Pop!_OS 20.10

Icon theme version: 2.1.0~1610392112~20.10~ef2be60

@siddhantladdha
Copy link

Can confirm the same for Pop OS 20.04 LTS. The problem seems to be with icons. I had opened the issue here but was redirected here.

@siddhantladdha
Copy link

To anyone trying to solve this issue on Pop OS, changing the icon theme from "Pop" to "Pop OS Branding" solves the problems. So does using any other default gnome themes (Adwaita, Breeze, HiContrast) solve all the problem for now atleast.

@isantop
Copy link
Contributor

isantop commented Oct 8, 2021

Those don't appear to be Pop-themed Icons. I'm not sure what's going on with the loading, but something definitely seems off.

I noticed you're still using Pop 20.10. Please be aware that 20.10 is not currently supported, and upgrading to/reinstalling with Pop 21.04 is advised.

I can't seem to replicate the issue in Pop 21.04. Loading this there I get:
Screenshot from 2021-10-08 10-53-58

@isantop isantop self-assigned this Oct 8, 2021
@isantop isantop added blocked Blocked due to missing required information bug Something isn't working labels Oct 8, 2021
@jacobgkau
Copy link
Member Author

jacobgkau commented Oct 8, 2021

I noticed you're still using Pop 20.10. Please be aware that 20.10 is not currently supported, and upgrading to/reinstalling with Pop 21.04 is advised.

I reported the issue before 21.04 was released. 😛

I am still seeing this on my primary machine, which was upgraded from 20.10 to 21.04:

image

But I'm not seeing it on another system with a fresh 21.04 install. I'll try to figure out what breaks it. This isn't specific to one machine, but could be specific to something else I tend to install or configure on my machines (although my notes in the OP indicated it was happening on fresh installs of 20.10-- maybe something got carried over that needs to be reset to fix this.)

@isantop
Copy link
Contributor

isantop commented Oct 8, 2021

Since those aren't Pop icons, I'll bet it's related to #94

@jacobgkau Do you have breeze-icon-theme installed?

@jacobgkau
Copy link
Member Author

@jacobgkau Do you have breeze-icon-theme installed?

I do, and can confirm installing that package is one way to recreate this on an otherwise-fresh 21.04 system.

@isantop
Copy link
Contributor

isantop commented Oct 11, 2021

I'm almost positive this is an inheritance issue then. Should track this via #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked due to missing required information bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants