Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Release 1.0.0 requires Rust 1.58.0 or later. #28

Open
rhanulewicz opened this issue Apr 1, 2022 · 2 comments
Open

Specify Release 1.0.0 requires Rust 1.58.0 or later. #28

rhanulewicz opened this issue Apr 1, 2022 · 2 comments

Comments

@rhanulewicz
Copy link

rhanulewicz commented Apr 1, 2022

The version of Rust given by 'cargo' on current Ubuntu 21.10 is 1.57.0 so the compilation fails. I found that installing via the curl script on their website rust-lang.org gets the most recent version of Rust

curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh

and this allowed system76-scheduler to compile.

Just wanted to make a note of this for others who come through trying to figure out why it won't compile (the errors do not make this clear). This dependency should probably be noted somewhere officially associated with the 1.0.0 release.

@maxiberta
Copy link

Aha! That explains why I needed to patch those tracing::debug!() calls to get the PPA builds working :-D (it's a trivial patch fortunately).

@NobodyXu
Copy link

NobodyXu commented May 5, 2022

Aha! That explains why I needed to patch those tracing::debug!() calls to get the PPA builds working :-D (it's a trivial patch fortunately).

That is the new formatting supported by rust-1.58.0.

It allows format string to reference variables directly, same as python f-string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants