screenshot: indicate correct version #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shouldn't actually impact behavior, because the #96 has a commit changing that, though it still needs some other changes (I guess including implementing |
Return version `1` for the screenshot portal to indicate that the `PickColor` method is not yet fully supported. This will allow clients to properly check and handle the missing method. Ref: flatpak/xdg-desktop-portal#766
FineFindus
force-pushed
the
fix/screenshot-version
branch
from
6690093 to
2b84de3
Compare
|
Thanks! I've updated the commit. |
ids1024
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return version
1for the screenshot portal to indicate that thePickColormethod is not yet fully supported. This will allow clients to properly check and handle the missing method.Ref: flatpak/xdg-desktop-portal#766