Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/240307 #349

Merged
merged 13 commits into from
Mar 11, 2024
Merged

Release/240307 #349

merged 13 commits into from
Mar 11, 2024

Conversation

sso-ashley
Copy link
Contributor

No description provided.

@sso-ashley sso-ashley requested a review from XiNiHa as a code owner March 8, 2024 11:14
@vercel Vercel
Copy link

vercel bot commented Mar 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 3:11pm

@sso-ashley
Copy link
Contributor Author

@XiNiHa ... 어제 리베이스하면서.. 뭔가 결제연동 리뉴얼 고친것도 다 들어간거 같은데.... src/content/release-notes/api-sdk/2024-03-08.mdx 이거랑 /src/content/docs/ko/v2-payment/pg/smartro-v2.mdx 이것만 반영되어야 하는데.. 어떡하죠

@XiNiHa
Copy link
Contributor

XiNiHa commented Mar 8, 2024

어 제가 지금은 힘들고 이따 자정 넘어서쯤 집 가서 고쳐둘게요.... 고치고 바로 나가면 되나요? 아님 급하시면 다른 분들 찾아보셔도..... 😇

@sso-ashley
Copy link
Contributor Author

sso-ashley commented Mar 8, 2024 •
edited
Loading

@XiNiHa 아녀 이거 월요일날 나갈거에여... 오후쯤에
천천히 해주셔도 됩니다

@sso-ashley
Copy link
Contributor Author

@XiNiHa lint에 맞추면 이렇게 이어지지 않고 막대가 끊겨요... 혹시 지금 상태로 올라갈 수 있게 lint 수정해주실 수 있나요?
image

@XiNiHa
Copy link
Contributor

XiNiHa commented Mar 10, 2024

음 막대가 끊기지 않도록 수정해 보겠습니다....

XiNiHa
XiNiHa reviewed Mar 11, 2024
View reviewed changes
src/content/docs/ko/v2-payment/pg/smartro-v2.mdx Outdated
Comment on lines 767 to 773
- 결제수단을 지정할 때 사용됩니다. 스마트로의 경우 가상계좌만 지원합니다.

- 가상계좌 : `VIRTUAL_ACCOUNT`

> `card` <mark style="color:blue;">**object**</mark>
>
> 카드
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?! 가상계좌인데 왜 카드가.... 어느 쪽이 맞나요? @sso-ashley @ltnscp9028

Copy link
Contributor

@XiNiHa XiNiHa Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 이제 보니 애초에 method가 enum값이 아닌데 문서가 이렇게 작성되어 있으면 좀 이상한 것 같아요.... 수정해서 올릴게요
근데 일단 가상계좌가 맞는지 카드가 맞는지는 알려 주셔야 문서를 고치든 날리든 할 것 같습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

제대로 썼는데... 왜 코드상은 다르져...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이게 method 안에 virtualAccount 가 들어가는거라 위에 - 가상계좌 : VIRTUAL_ACCOUNT 부분 삭제하고 위에 method랑 막대로 연결되면 될 것 같아요 @XiNiHa

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제대로 썼는데... 왜 코드상은 다르져...?

내용이 비슷하게 생기긴 했는데 😂 섹션이 거기가 아니고 키인 쪽이에요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image @XiNiHa 여기는 card만 지원되는게 맞아요! 빌링키 발급은 카드만 지원합니다.

@sso-ashley
Copy link
Contributor Author

@XiNiHa 니큐가 lint 고쳐주시면서 들여쓰기가 틀어 진거 같은데.. 이것 좀 맞춰주세요
image

@XiNiHa XiNiHa force-pushed the release/240307 branch 3 times, most recently from 33d7206 to 7a284b2 Compare March 11, 2024 12:42
@XiNiHa XiNiHa force-pushed the main branch 2 times, most recently from f5b2639 to 24fe328 Compare March 11, 2024 12:45
@XiNiHa XiNiHa force-pushed the release/240307 branch 2 times, most recently from 737bbc4 to 59e46cb Compare March 11, 2024 12:52
@sso-ashley
Update smartro-v2.mdx
b0f3e76 
 ParamTree 추가
@sso-ashley sso-ashley merged commit c0e4fb1 into main Mar 11, 2024
4 checks passed
@sso-ashley sso-ashley deleted the release/240307 branch March 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiNiHa XiNiHa XiNiHa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sso-ashley @XiNiHa @ltnscp9028