Refactor LinkHandling for TYPO3 9.5 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add LinkBuilder and LinkHandler for Shopware. - Remove all LinkResolver - Move Recordlist/Linkhandler into correct directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As introduced in TYPO3 8.3 there were some changes at LinkHandling. After installation this extension into a TYPO3 9.5, I have found some parts that won't work anymore like expected.
In this pull request I want to show you my refactoring of LinkHandling for TYPO3 9.5. First of all I have implemented a new LinkHandler to transforming the link hrefs to resources.
Portrino\PxShopware\LinkHandling\ShopwareLinkHandler
Then I replaced your LinkResolvers with a ShopwareLinkBuilder to get the correct URI from the resources, just like the LinkResolvers did before.
Portrino\PxShopware\LinkHandling\ShopwareLinkBuilder
At last your LinkHandler for the Recordlist were moved into the Recordlist folder.
Also at this part I have fixed the default Item-Partials to use item.uri instead of item.url