Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dirty fixes with proper fixes #30

Open
nvbln opened this issue Apr 6, 2023 · 0 comments
Open

Replace dirty fixes with proper fixes #30

nvbln opened this issue Apr 6, 2023 · 0 comments

Comments

@nvbln
Copy link
Collaborator

nvbln commented Apr 6, 2023

PR #29 contains some much needed fixes, but they are not meant to be permanent. Instead the issue itself should be fixed rather than using workarounds. This issue is meant to track this.
The issues are the following:

  • The communication duration with Stytra is highly variable and can take up to ~3s. Currently fixed by waiting for 5 seconds to make sure that communication finished.
  • When saving the data, the queue with planes is not completely emptied. Therefore it can miss the last plane. Again, it is currently fixed by waiting for 5 seconds.
  • The motor sometimes move double the z step size as it is triggered twice. This is currently solved by forcing the internal frame count to have a small number once the z motor is moved (such that it does not get triggered again).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant