Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State with signals? #101

Open
vigji opened this issue Nov 4, 2020 · 3 comments
Open

State with signals? #101

vigji opened this issue Nov 4, 2020 · 3 comments
Labels
Refactor Improve source code readability, reusability or structure

Comments

@vigji
Copy link
Member

vigji commented Nov 4, 2020

I was wondering whether having the State refactored as a QtObject would make sense, in that it would add it the possibility of emitting signals to synch the GUI. This would make easier to glue together different widgets that see each other only through the state. All the widgetish things will still be out of it, so this would preserve the distinction between the state and the user interface, but might streamline some parts of the code.

@vilim
Copy link
Member

vilim commented Nov 4, 2020

Sounds reasonable. Perhapse the evented dataclasses from napari could be considered?

@vigji
Copy link
Member Author

vigji commented Nov 4, 2020

I will investigate!

@diegoasua
Copy link
Member

We might want to prioritise this. It will help a lot in subsequent developement!

@diegoasua diegoasua added the Refactor Improve source code readability, reusability or structure label Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Improve source code readability, reusability or structure
Projects
None yet
Development

No branches or pull requests

3 participants