Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract the structure a bit #79

Open
vilim opened this issue Aug 14, 2020 · 2 comments
Open

Abstract the structure a bit #79

vilim opened this issue Aug 14, 2020 · 2 comments
Assignees
Labels
Refactor Improve source code readability, reusability or structure

Comments

@vilim
Copy link
Member

vilim commented Aug 14, 2020

Provide abstract classes and (at least) 3 implementations for each:

Abstract Missing Mock Our LS Extra
Laser [x] [ ] [x] [x] []
Camera [x] [x] [x] [] e.g. Andor
Scanning [x] [x] [x] [x] [] e.g. LabJack
External comm. [x] [x] [x] [x] []

This would also allow sashimi to be used on e.g. lightfield (supporing Absent implementations) without modifications

@diegoasua
Copy link
Member

Do we want a laser missing implementation? Seems like an overkill for now! Also #61 itself is about LabJack and so far we have agreed that we will help anyone trying to implement an Andor or whatever camera here, but there are no plans to write a wrapper for it. However we maintain that other issue for Labjack support. Therefore can we close this after #120 is eventually merged?

@diegoasua
Copy link
Member

diegoasua commented Feb 21, 2021

Also related, start factoring out code to scopecuisine, for example starting with #124

@diegoasua diegoasua added the Refactor Improve source code readability, reusability or structure label Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Improve source code readability, reusability or structure
Projects
None yet
Development

No branches or pull requests

2 participants