Replace Font Awesome reset icon with Nova x-circle icon #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schroedan did you have any time to review this ? This is pretty confusing on our side Thanks, |
|
Please excuse. We are not currently using the package in any of our projects and do not have much time to take care of it. |
schroedan
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using Nova's built-in icon for delete/cancel/false instead, we remove the Font Awesome dependency and the need to manually copy those font files into the project, fixing #4 .
I also had to lock in flatpickr's version to 4.6.7 because of this unusual webpack-related bug that was happening only in the production build: https://stackoverflow.com/questions/66551943/flatpickr-issue-cannot-access-e-before-initialization